Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unsubscribe from optimistic inflight subscription #275

Closed
wants to merge 1 commit into from
Closed

Fix unsubscribe from optimistic inflight subscription #275

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/centrifuge.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1379,9 +1379,16 @@ export class Centrifuge extends (EventEmitter as new () => TypedEventEmitter<Cli
}

protected _unsubscribe(sub: Subscription) {
if (!this._isConnected()) {
// Optimistic subscription could be sent together with connect command in one frame, so
// Centrifuge can be in the connecting state – but we still need to send unsubscribe frame
// to the server.
// @ts-ignore – we are hiding some symbols from public API autocompletion.
const isSubOptimisticallySent = this._isConnecting() && sub._inflight;

if (!this._isConnected() && !isSubOptimisticallySent) {
return;
}

const req = {
channel: sub.channel
};
Expand Down