Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with SwiftProtobuf 1.27.0 and older versions #102

Merged
merged 1 commit into from
Jul 19, 2024

Conversation

FZambia
Copy link
Member

@FZambia FZambia commented Jul 17, 2024

Relates #101

SwiftProtobuf changed the behaviour and now returns noBytesAvailable error at the end of stream. Here we become independent from SwiftProtobuf 's BinaryDelimited.parse when decoding varint-delimited messages. It works on old versions and new version.

Copy link

@melanu1991 melanu1991 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that does the trick! works for me like a charm!

@FZambia FZambia merged commit f8c01aa into master Jul 19, 2024
2 checks passed
@FZambia FZambia deleted the protobuf_compat branch July 19, 2024 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants