Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the TokenGetter to a weak reference to prevent a memory leak in the client.
The client holds the
CentrifugeClientConfig
which has a strong reference to aCentrifugeConnectionTokenGetter
The problem can happen once the
CentrifugeConnectionTokenGetter
implementation is the one that is holding a strong reference to theClient
.This creates a circular strong reference Between the App -> Client -> Config -> TokenGetter -> App