Fix CI Integration test and unit test #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VallariAg
force-pushed
the
fix-integration-ci
branch
2 times, most recently
from
ec7e517
to
426c596
Compare
VallariAg
changed the title
VallariAg
force-pushed
the
fix-integration-ci
branch
3 times, most recently
from
37e7d3f
to
fb72820
Compare
|
ceph/teuthology#1952 needs to be reviewed and merged before t-api integration test fix (this PR) Update: teuthology's integration CI test has been fixed, this PR is ready for review now! |
VallariAg
force-pushed
the
fix-integration-ci
branch
from
fb72820
to
16b69f6
Compare
Default python version in focal is python3.8 which is breaking integration CI builds on t-api PRs with: `ERROR: Package 'teuthology-1.1.1.dev729-g861a8dcf' requires a different Python: 3.8.10 not in '>=3.10'` Recently, we upgraded the minimum teuthology version to support python3.10, which could be the reason of the above CI failures. Signed-off-by: Vallari Agrawal <[email protected]>
VallariAg
force-pushed
the
fix-integration-ci
branch
from
16b69f6
to
51c49d2
Compare
Signed-off-by: Vallari Agrawal <[email protected]>
VallariAg
changed the title
4 tasks
Devansh3712
approved these changes
Jun 17, 2024
4 tasks
kamoltat
approved these changes
Jun 17, 2024
|
Thanks for the reviews! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Dockefile, use base image 'ubuntu:jammy' instead of focal.
Reason:
Default python version in focal is python3.8 which is breaking
integration CI builds on t-api PRs with:
ERROR: Package 'teuthology-1.1.1.dev729-g861a8dcf' requires a different Python: 3.8.10 not in '>=3.10'Recently, we upgraded the minimum teuthology version to support
python3.10, which could be the reason of the above CI failures.
Use ubuntu-22.04 and python 3.10
Contribution Guidelines
To sign and test your commits, please refer to Contibution guidelines.
Checklist