Fixes for teuthology-node-cleanup #1949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fix the return type and docstring, which were inconsistent. Signed-off-by: Zack Cerza <[email protected]>
kamoltat
reviewed
May 29, 2024
|
Some context as to why you are fixing this in the PR description would be super helpful, thanks! |
kamoltat
previously approved these changes
Jun 17, 2024
scripts/node_cleanup.py
Outdated
Comment on lines
24
to
25
| owner_nodes = by_owner.setdefault(node['locked_by'], []) | ||
| owner_nodes.append(node) |
There was a problem hiding this comment.
I know that owner_nodes is a reference to by_owner, can't we just purely use by_owner? Am I missing something?
There was a problem hiding this comment.
by_owner is a dict where keys are e.g. "scheduled_zack@teuthology", and values are lists of dicts containing node data, whereas owner_nodes is a reference to one of those lists - but you're right that there's no real point in holding this reference.
I'll replace the above two lines with:
by_owner.setdefault(node['locked_by'], []).append(node)
Signed-off-by: Zack Cerza <[email protected]>
Signed-off-by: Zack Cerza <[email protected]>
kamoltat
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This mainly gets the command working without having to invoke with
--ownerfor each user who has jobs running.