-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various updates to support newer OSes #1953
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zack Cerza <[email protected]>
Signed-off-by: Zack Cerza <[email protected]>
Signed-off-by: Zack Cerza <[email protected]>
Signed-off-by: Zack Cerza <[email protected]>
When attempting to provision a CentOS node, if the user leaves out ".stream", try searching for that as well. Signed-off-by: Zack Cerza <[email protected]>
Until it can get updated. Signed-off-by: Zack Cerza <[email protected]>
Signed-off-by: Zack Cerza <[email protected]>
Signed-off-by: Zack Cerza <[email protected]>
... instead of hardcoding, which is more error-prone. Signed-off-by: Zack Cerza <[email protected]>
This fixes an inconsistency where we'd change "centosX.stream" to "centosX" when a job starts, submitting that to paddles. Signed-off-by: Zack Cerza <[email protected]>
VallariAg
previously approved these changes
Jun 11, 2024
Signed-off-by: Zack Cerza <[email protected]>
Signed-off-by: Zack Cerza <[email protected]>
@VallariAg I found a bug that affected CentOS Stream reimages; the last two commits fix it. Could you review those as well? Thanks! |
Tested on my local docker container setup, works great and fixed the galaxy ansible failure for me |
VallariAg
approved these changes
Jun 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - works for me too!
14 tasks
zmc
added a commit
to zmc/ceph
that referenced
this pull request
Jun 19, 2024
See: https://sentry.ceph.com/share/issue/21ed88d705854238bdafbf6711e795ee/ They're strings, not floats. This surfaced as a result of ceph/teuthology#1953 Signed-off-by: Zack Cerza <[email protected]>
idryomov
pushed a commit
to idryomov/ceph
that referenced
this pull request
Jun 19, 2024
See: https://sentry.ceph.com/share/issue/21ed88d705854238bdafbf6711e795ee/ They're strings, not floats. This surfaced as a result of ceph/teuthology#1953 Signed-off-by: Zack Cerza <[email protected]>
idryomov
pushed a commit
to idryomov/ceph
that referenced
this pull request
Jun 19, 2024
See: https://sentry.ceph.com/share/issue/21ed88d705854238bdafbf6711e795ee/ They're strings, not floats. This surfaced as a result of ceph/teuthology#1953 Signed-off-by: Zack Cerza <[email protected]>
idryomov
pushed a commit
to idryomov/ceph
that referenced
this pull request
Jun 20, 2024
See: https://sentry.ceph.com/share/issue/21ed88d705854238bdafbf6711e795ee/ They're strings, not floats. This surfaced as a result of ceph/teuthology#1953 Signed-off-by: Zack Cerza <[email protected]> (cherry picked from commit 260a45a)
idryomov
pushed a commit
to idryomov/ceph
that referenced
this pull request
Jun 20, 2024
See: https://sentry.ceph.com/share/issue/21ed88d705854238bdafbf6711e795ee/ They're strings, not floats. This surfaced as a result of ceph/teuthology#1953 Signed-off-by: Zack Cerza <[email protected]> (cherry picked from commit 260a45a)
idryomov
pushed a commit
to idryomov/ceph
that referenced
this pull request
Jun 20, 2024
See: https://sentry.ceph.com/share/issue/21ed88d705854238bdafbf6711e795ee/ They're strings, not floats. This surfaced as a result of ceph/teuthology#1953 Signed-off-by: Zack Cerza <[email protected]> (cherry picked from commit 260a45a)
yuriw
pushed a commit
to ceph/ceph-ci
that referenced
this pull request
Jun 27, 2024
See: https://sentry.ceph.com/share/issue/21ed88d705854238bdafbf6711e795ee/ They're strings, not floats. This surfaced as a result of ceph/teuthology#1953 Signed-off-by: Zack Cerza <[email protected]> (cherry picked from commit 260a45a) (cherry picked from commit c675506)
yuriw
pushed a commit
to ceph/ceph-ci
that referenced
this pull request
Jul 1, 2024
See: https://sentry.ceph.com/share/issue/21ed88d705854238bdafbf6711e795ee/ They're strings, not floats. This surfaced as a result of ceph/teuthology#1953 Signed-off-by: Zack Cerza <[email protected]> (cherry picked from commit 260a45a) (cherry picked from commit 7fb2281)
yuriw
pushed a commit
to ceph/ceph-ci
that referenced
this pull request
Jul 2, 2024
See: https://sentry.ceph.com/share/issue/21ed88d705854238bdafbf6711e795ee/ They're strings, not floats. This surfaced as a result of ceph/teuthology#1953 Signed-off-by: Zack Cerza <[email protected]> (cherry picked from commit 260a45a) (cherry picked from commit 7fb2281)
idryomov
pushed a commit
to ceph/ceph
that referenced
this pull request
Jul 8, 2024
See: https://sentry.ceph.com/share/issue/21ed88d705854238bdafbf6711e795ee/ They're strings, not floats. This surfaced as a result of ceph/teuthology#1953 Signed-off-by: Zack Cerza <[email protected]> (cherry picked from commit 260a45a) (cherry picked from commit 7fb2281)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This isn't exhaustive; these are issues I ran into when updating ceph-devstack to work with centos 9 hosts.