console: Rework power on/off retry mechanism #1955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A very small run completed successfully: https://pulpito-ng.ceph.com/zack-2024-06-11_22:04:48-orch:cephadm:smoke-small-main-distro-default-smithi/ |
We were only ever issuing the inital request once; Now, after five unsuccessful checks to see that the node is in the desired state, we re-issue the request but do not reset the clock. We were also checking the power state immediately after sending the request, which is unhelpful as the operation will never complete that quickly. Now, we sleep at least once. Signed-off-by: Zack Cerza <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were only ever issuing the inital request once; Now, after five unsuccessful checks to see that the node is in the desired state, we re-issue the request but do not reset the clock.
We were also checking the power state immediately after sending the request, which is unhelpful as the operation will never complete that quickly. Now, we sleep at least once.