Replace deprecated datetime.utcnow() calls #1977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kshtsk
reviewed
Jul 21, 2024
| @@ -275,7 +275,7 @@ def unlock_targets(job_config): | |||
|
|
|||
|
|
|||
| def run_with_watchdog(process, job_config): | |||
| job_start_time = datetime.utcnow() | |||
| job_start_time = datetime.datetime.now(datetime.timezone.utc) | |||
There was a problem hiding this comment.
looks gut, I know it must be the same to use shorter form datetime.UTC, but why did you prefer longer variant, for the reference:
DeprecationWarning: datetime.datetime.utcnow() is deprecated and scheduled for removal in a future version. Use timezone-aware objects to represent datetimes in UTC: datetime.datetime.now(datetime.UTC).
There was a problem hiding this comment.
Because they didn't make it available as datetime.UTC until 3.11 🙃
https://docs.python.org/3/library/datetime.html#datetime.UTC
kshtsk
reviewed
Jul 21, 2024
| @@ -19,6 +19,8 @@ jobs: | |||
| python: "3.10" | |||
| - os: ubuntu-22.04 | |||
| python: "3.11" | |||
| - os: ubuntu-24.04 | |||
| python: "3.12" | |||
Signed-off-by: Zack Cerza <[email protected]>
zmc
force-pushed
the
utcnow
branch
3 times, most recently
from
692c49d
to
80fb908
Compare
kshtsk
reviewed
Jul 23, 2024
kshtsk
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.