Fix access denied from psutil on macOS #1985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kshtsk
force-pushed
the
wip-access-denied
branch
from
704fe42
to
d6e3bca
Compare
zmc
reviewed
Aug 2, 2024
.github/workflows/integration.yml
Outdated
| - uses: actions/checkout@v2 | ||
| - uses: actions/checkout@v4 | ||
| - name: Install docker-compose | ||
| run: sudo apt-get install -y docker-compose |
There was a problem hiding this comment.
This didn't really work, and the issue is intermittent. Let's leave it out of this PR and see if a simple retry gets us past the issue for now
There was a problem hiding this comment.
I was trying to fix it fast, but right, dropping it for now, am not sure missing docker-compose is gonna be fixed by retrying :-D
kshtsk
force-pushed
the
wip-access-denied
branch
from
d6e3bca
to
fe2cab3
Compare
|
the integration failure is unrelated |
added 2 commits
August 2, 2024 19:26
On macOS dispatcher while trying to go through process list gets stuck on some of the system processes like launchd, logd, systemstats, etc. and quites unexpectedly with PermissionError and psutil.AccessDenied exceptions. Fixes: https://tracker.ceph.com/issues/67313 Signed-off-by: Kyr Shatskyy <[email protected]>
Fix unhandled exception psutilAccessDenied in process_matches_run(). Signed-off-by: Kyr Shatskyy <[email protected]>
kshtsk
force-pushed
the
wip-access-denied
branch
from
fe2cab3
to
d218c61
Compare
zmc
approved these changes
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On macOS dispatcher while trying to go through process list gets stuck
on some of the system processes like launchd, logd, systemstats, etc.
and quites unexpectedly with PermissionError and psutil.AccessDenied
exceptions.
Fixes: https://tracker.ceph.com/issues/67313