bunch of downburst fixes #1990
Merged
bunch of downburst fixes #1990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kshtsk
commented
Aug 2, 2024
| @@ -1127,7 +1127,8 @@ def _ssh_keyscan(hostname): | |||
| for line in p.stdout: | |||
| host, key = line.strip().decode().split(' ', 1) | |||
| keys.append(key) | |||
| return sorted(keys)[0] | |||
| if len(keys) > 0: | |||
| return sorted(keys)[0] | |||
kshtsk
force-pushed
the
wip-downburst-fixes
branch
6 times, most recently
from
5cdac04
to
5d69d3a
Compare
added 3 commits
August 7, 2024 22:32
If downburst gets hostname as an argument which does not have a username@ prefix (does not include @-symbol) there is an index out of range error will occur, which we, obviously, don't want and wish to allow hostnames don't use login names. Signed-off-by: Kyr Shatskyy <[email protected]>
Need to passthrough the PATH to downburst environment, otherwise on some system like macos where mkisofs installed via homebrew it cannot be found. Signed-off-by: Kyr Shatskyy <[email protected]>
A host may not have any keys, so _ssh_keyscan should return None,
instead of failing with error:
IndexError: list index out of range
Fixes: dbd55e3
Signed-off-by: Kyr Shatskyy <[email protected]>
kshtsk
force-pushed
the
wip-downburst-fixes
branch
from
5d69d3a
to
837a0e1
Compare
zmc
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.