lock.ops.unlock_one_safe: Invert run-match logic #2036
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When unlock_one_safe is called with run_name, the caller means to express "unlock this node if it belongs to this run". When it is called with run_name and job_id, it means "unlock this node if it belongs to this job in this run". We had inverted the logic, causing leaks on reimage failures. Signed-off-by: Zack Cerza <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When unlock_one_safe is called with run_name, the caller means to express "unlock this node if it belongs to this run".
When it is called with run_name and job_id, it means "unlock this node if it belongs to this job in this run".
We had inverted the logic, causing leaks on reimage failures.