-
Notifications
You must be signed in to change notification settings - Fork 307
suite: Filter YAML fragments for distro, version #2037
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@yuriw please test this branch |
@zmc what cases do you suggest looking at? |
@yuriw doesn't matter, this is only about filtering distros |
@zmc This run https://pulpito.ceph.com/yuriw-2025-03-24_19:43:11-upgrade:pacific-x-reef-release-distro-default-smithi/
|
@yuriw what do you think the behavior ought to be, if |
@kamoltat or @VallariAg, please take a look when you get a chance |
ping @kamoltat @VallariAg |
The behavior of --distro{,-version} was never well-defined. With this change, they can independently be used to provide a default for jobs which don't otherwise specify a value; and more importantly, perform a post-merge filter looking at each job's values, rejecting those which don't match. This behavior should be more intuitive and more easy to understand. Signed-off-by: Zack Cerza <[email protected]>
We were only looking in ceph.git; look in e.g. ceph-ci.git if that is the ceph repo being tested. Signed-off-by: Zack Cerza <[email protected]>
The behavior of --distro{,-version} was never well-defined. With this change, they can independently be used to provide a default for jobs which don't otherwise specify a value; and more importantly, perform a post-merge filter looking at each job's values, rejecting those which don't match. This behavior should be more intuitive and more easy to understand.