Skip to content

Conversation

zmc
Copy link
Member

@zmc zmc commented Mar 20, 2025

The behavior of --distro{,-version} was never well-defined. With this change, they can independently be used to provide a default for jobs which don't otherwise specify a value; and more importantly, perform a post-merge filter looking at each job's values, rejecting those which don't match. This behavior should be more intuitive and more easy to understand.

@zmc
Copy link
Member Author

zmc commented Mar 20, 2025

@yuriw please test this branch

@yuriw
Copy link
Contributor

yuriw commented Mar 20, 2025

@zmc what cases do you suggest looking at?

@zmc
Copy link
Member Author

zmc commented Mar 20, 2025

@yuriw doesn't matter, this is only about filtering distros

@yuriw
Copy link
Contributor

yuriw commented Mar 24, 2025

@zmc This run https://pulpito.ceph.com/yuriw-2025-03-24_19:43:11-upgrade:pacific-x-reef-release-distro-default-smithi/
was scheduled as:

teuthology-suite -v --ceph-repo $CEPH_REPO -c $CEPH_BRANCH --suite-repo $SUITE_REPO --suite-branch $SUITE_BRANCH -m $MACHINE_NAME -s upgrade/pacific-x -k $DISTRO -p $PRIO -e $CEPH_QA_MAIL -l $LIMIT -S $SHA1 --force-priority --subset 111/120000 --distro ubuntu --distro-version 20.04

@zmc
Copy link
Member Author

zmc commented Mar 24, 2025

@yuriw what do you think the behavior ought to be, if -d/-D are not used and the generated job(s) do not specify os_type/os_version?

@zmc zmc marked this pull request as ready for review July 8, 2025 19:18
@zmc zmc requested a review from a team as a code owner July 8, 2025 19:18
@zmc zmc requested review from kamoltat and VallariAg and removed request for a team July 8, 2025 19:18
@zmc
Copy link
Member Author

zmc commented Aug 27, 2025

@kamoltat or @VallariAg, please take a look when you get a chance

@zmc
Copy link
Member Author

zmc commented Sep 15, 2025

ping @kamoltat @VallariAg

zmc added 2 commits September 26, 2025 13:23
The behavior of --distro{,-version} was never well-defined. With this change,
they can independently be used to provide a default for jobs which don't
otherwise specify a value; and more importantly, perform a post-merge filter
looking at each job's values, rejecting those which don't match. This behavior
should be more intuitive and more easy to understand.

Signed-off-by: Zack Cerza <[email protected]>
We were only looking in ceph.git; look in e.g. ceph-ci.git if that is the ceph
repo being tested.

Signed-off-by: Zack Cerza <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants