Begin transitioning to uv #2081
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zmc
requested review from
kamoltat and
amathuria
and removed request for
a team
kshtsk
reviewed
Sep 9, 2025
| "xmltodict", | ||
| ] | ||
| openstack = [ | ||
| "openstacksdk", |
There was a problem hiding this comment.
After the teuthology-openstack revived merged the openstacksdk became required default dependency.
There was a problem hiding this comment.
Just to confirm that when using pip install from this branch I've got this:
$ teuthology --version
Traceback (most recent call last):
File "/***/v/teuthology-uv/bin/teuthology", line 3, in <module>
from scripts.run import main
File "/****/teuthology/scripts/run.py", line 33, in <module>
import teuthology.run
File "/****/teuthology/teuthology/run.py", line 8, in <module>
from teuthology import report
File "/****/teuthology/teuthology/report.py", line 12, in <module>
import teuthology.exporter
File "/****/teuthology/teuthology/exporter.py", line 11, in <module>
import teuthology.dispatcher
File "/****/teuthology/teuthology/dispatcher/__init__.py", line 22, in <module>
from teuthology.dispatcher import supervisor
File "/****/teuthology/teuthology/dispatcher/supervisor.py", line 11, in <module>
from teuthology import exporter, dispatcher, kill, report, safepath
File "/****/teuthology/teuthology/kill.py", line 17, in <module>
from teuthology.lock import ops as lock_ops
File "/****/teuthology/teuthology/lock/ops.py", line 11, in <module>
import teuthology.orchestra.remote
File "/****/teuthology/teuthology/orchestra/remote.py", line 6, in <module>
import teuthology.lock.util
File "/****/teuthology/teuthology/lock/util.py", line 6, in <module>
import teuthology.provision.downburst
File "/****/teuthology/teuthology/provision/__init__.py", line 11, in <module>
from teuthology.provision import openstack
File "/****/teuthology/teuthology/provision/openstack.py", line 14, in <module>
from teuthology.openstack import OpenStack, OpenStackInstance
File "/****/teuthology/teuthology/openstack/__init__.py", line 48, in <module>
from openstack import connection as openstack_connection
ModuleNotFoundError: No module named 'openstack'
kshtsk
reviewed
Sep 9, 2025
kshtsk
reviewed
Sep 9, 2025
kshtsk
reviewed
Sep 9, 2025
|
Instead of the commit "scripts: Delay imports for performance" within this PR or as follow up PR, I would suggest to drop scripts by moving the argument parsing code to corresponding module and adjusting |
Open
kshtsk
requested changes
Sep 9, 2025
Signed-off-by: Zack Cerza <[email protected]>
Signed-off-by: Zack Cerza <[email protected]>
Signed-off-by: Zack Cerza <[email protected]>
To a version that support python 3.13 Signed-off-by: Zack Cerza <[email protected]>
Much of this is simply removing things we don't have to be doing now that we're using uv. It also consolidates the different sections for RPM-based distros. Signed-off-by: Zack Cerza <[email protected]>
Signed-off-by: Zack Cerza <[email protected]>
Signed-off-by: Zack Cerza <[email protected]>
Signed-off-by: Zack Cerza <[email protected]>
For now, use a very narrow ruleset. We should expand to use more later. Signed-off-by: Zack Cerza <[email protected]>
Signed-off-by: Zack Cerza <[email protected]>
Signed-off-by: Zack Cerza <[email protected]>
Signed-off-by: Kyr Shatskyy <[email protected]>
Because the teuthology code is building in container after copying source code from local directory, but no corresponding git repo copied, the setuptools-scm cannot determine teuthology version. So in order to produce the package we just provide dummy version 0.0.0 using environment variable: SETUPTOOLS_SCM_PRETEND_VERSION_FOR_TEUTHOLOGY Signed-off-by: Kyr Shatskyy <[email protected]>
Signed-off-by: Kyr Shatskyy <[email protected]>
And also drop an unnecessary tr invocation. Signed-off-by: Zack Cerza <[email protected]>
Interesting idea - let's save that for a follow-up |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.