Fix: handle attached_volumes field when fetching volumes from openstack #2088
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kshtsk
reviewed
Sep 17, 2025
teuthology/openstack/__init__.py
Outdated
| volumes = self['os-extended-volumes:volumes_attached'] | ||
| return [volume['id'] for volume in volumes ] | ||
| info = self.info or {} | ||
| #Some clouds use attached_volumes instead of os-extended-volumes:volumes_attached |
There was a problem hiding this comment.
Drop this comment, the code below is pretty straightforward. It's better give this explanation in the commit description.
deepssin
force-pushed
the
openstack_config
branch
from
c4aade9 to
00daa0b
Compare
Some clouds use attached_volumes instead of os-extended-volumes:volumes_attached
deepssin
force-pushed
the
openstack_config
branch
from
00daa0b to
27c0b64
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some OpenStack deployments, the server JSON includes 'attached_volumes'
instead of
os-extended-volumes:volumes_attached. The existingget_volumes function only checked the latter, which caused it to always
return an empty list on these clouds.
This patch updates get_volumes() to:
is not present
With this change, teardown logic (volume cleanup on destroy) works
correctly across both types of openstack responses.