-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: verify time event proofs from eth rpc client and calculate time #522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dav1do
temporarily deployed
to
github-tests-2024
September 9, 2024 22:31
— with
GitHub Actions
Inactive
dav1do
force-pushed
the
feat/aes-273-eth-time-events
branch
from
September 12, 2024 01:01
6835ef1
to
535ada8
Compare
dav1do
force-pushed
the
feat/aes-274-timestamp-time-events
branch
from
September 12, 2024 01:03
9a7554a
to
7f9b650
Compare
dav1do
temporarily deployed
to
github-tests-2024
September 12, 2024 01:14
— with
GitHub Actions
Inactive
dav1do
force-pushed
the
feat/aes-273-eth-time-events
branch
from
September 16, 2024 16:46
535ada8
to
98305a9
Compare
dav1do
force-pushed
the
feat/aes-274-timestamp-time-events
branch
from
September 17, 2024 15:55
7f9b650
to
9594d4e
Compare
this is done in another PR as well
Used to validate time event anchor proofs and determine time from block
dav1do
force-pushed
the
feat/aes-274-timestamp-time-events
branch
from
September 17, 2024 16:07
9594d4e
to
216c489
Compare
dav1do
temporarily deployed
to
github-tests-2024
September 17, 2024 16:23
— with
GitHub Actions
Inactive
nathanielc
approved these changes
Sep 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with one question below
dav1do
temporarily deployed
to
github-tests-2024
September 17, 2024 19:11
— with
GitHub Actions
Inactive
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is currently not used outside of tests. It includes the logic to use a time event to find the corresponding block on an the appropriate chain, validate the proof, and return a timestamp. We will need to add CLI flags to pass in the RPC URLs and there is more work to actually persist the transaction/proof information locally so we don't hit the RPC endpoints so frequently, and more importantly, to actually store the discovered timestamp so we can use it for conclusions.