Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: verify time event proofs from eth rpc client and calculate time #522

Merged
merged 4 commits into from
Sep 17, 2024

Conversation

dav1do
Copy link
Contributor

@dav1do dav1do commented Sep 9, 2024

This is currently not used outside of tests. It includes the logic to use a time event to find the corresponding block on an the appropriate chain, validate the proof, and return a timestamp. We will need to add CLI flags to pass in the RPC URLs and there is more work to actually persist the transaction/proof information locally so we don't hit the RPC endpoints so frequently, and more importantly, to actually store the discovered timestamp so we can use it for conclusions.

@dav1do dav1do requested a review from a team as a code owner September 9, 2024 22:21
@dav1do dav1do requested review from gvelez17 and removed request for a team September 9, 2024 22:21
Copy link

linear bot commented Sep 9, 2024

@dav1do dav1do force-pushed the feat/aes-274-timestamp-time-events branch from 9a7554a to 7f9b650 Compare September 12, 2024 01:03
Base automatically changed from feat/aes-273-eth-time-events to main September 16, 2024 17:47
@dav1do dav1do force-pushed the feat/aes-274-timestamp-time-events branch from 7f9b650 to 9594d4e Compare September 17, 2024 15:55
this is done in another PR as well
Used to validate time event anchor proofs and determine time from block
@dav1do dav1do force-pushed the feat/aes-274-timestamp-time-events branch from 9594d4e to 216c489 Compare September 17, 2024 16:07
Copy link
Collaborator

@nathanielc nathanielc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one question below

event-svc/src/event/validator/time.rs Outdated Show resolved Hide resolved
@dav1do dav1do added this pull request to the merge queue Sep 17, 2024
Merged via the queue into main with commit 2bc4978 Sep 17, 2024
5 checks passed
@dav1do dav1do deleted the feat/aes-274-timestamp-time-events branch September 17, 2024 19:46
@smrz2001 smrz2001 mentioned this pull request Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants