Duration.ofMillis timeout and wait

cerberustesting · Jan 10, 2025 · 6507bd7 · 6507bd7
1 parent 868c3d8
commit 6507bd7
Showing 1 changed file with 6 additions and 7 deletions.
diff --git a/source/src/main/java/org/cerberus/core/engine/execution/impl/RobotServerService.java b/source/src/main/java/org/cerberus/core/engine/execution/impl/RobotServerService.java
@@ -71,7 +71,6 @@
 import java.net.URL;
 import java.time.Duration;
 import java.util.*;
-import java.util.concurrent.TimeUnit;
 import java.util.logging.Level;
 
 import org.cerberus.core.crud.entity.Application;
@@ -1320,16 +1319,16 @@ public void setOptionsTimeout(Session session, Integer timeout) {
             if ((session.getDriver() != null) && (session.getAppiumDriver() == null) && (session.getCerberus_selenium_pageLoadTimeout() != timeout)) {
                 LOG.debug("Setting Selenium Robot Options (pageLoadTimeout & setScriptTimeout) timeout to : {}", timeout);
                 WebDriver driver = session.getDriver();
-                driver.manage().timeouts().pageLoadTimeout(timeout, TimeUnit.MILLISECONDS);
-                driver.manage().timeouts().setScriptTimeout(timeout, TimeUnit.MILLISECONDS);
+                driver.manage().timeouts().pageLoadTimeout(Duration.ofMillis(timeout));
+                driver.manage().timeouts().setScriptTimeout(Duration.ofMillis(timeout));
                 session.setCerberus_selenium_pageLoadTimeout(timeout);
                 session.setCerberus_selenium_setScriptTimeout(timeout);
             }
 
             if ((session.getAppiumDriver() != null) && (session.getCerberus_appium_wait_element() != timeout)) {
                 LOG.debug("Setting Appium Robot Options timeout to : {}", timeout);
                 AppiumDriver appiumDriver = session.getAppiumDriver();
-                appiumDriver.manage().timeouts().implicitlyWait(timeout, TimeUnit.MILLISECONDS);
+                appiumDriver.manage().timeouts().implicitlyWait(Duration.ofMillis(timeout));
             }
             session.setCerberus_appium_wait_element(timeout);
         }
@@ -1374,12 +1373,12 @@ public void setOptionsToDefault(Session session) {
             WebDriver driver = session.getDriver();
             if ((driver != null) && (session.getAppiumDriver() == null) && (session.getCerberus_selenium_pageLoadTimeout() != session.getCerberus_selenium_pageLoadTimeout_default())) {
                 LOG.debug("Setting Selenium Robot Options (pageLoadTimeout) timeout to : {}", session.getCerberus_selenium_pageLoadTimeout_default());
-                driver.manage().timeouts().pageLoadTimeout(session.getCerberus_selenium_pageLoadTimeout_default(), TimeUnit.MILLISECONDS);
+                driver.manage().timeouts().pageLoadTimeout(Duration.ofMillis(session.getCerberus_selenium_pageLoadTimeout_default()));
                 session.setCerberus_selenium_pageLoadTimeout(session.getCerberus_selenium_pageLoadTimeout_default());
             }
             if ((driver != null) && (session.getAppiumDriver() == null) && (session.getCerberus_selenium_setScriptTimeout() != session.getCerberus_selenium_setScriptTimeout_default())) {
                 LOG.debug("Setting Selenium Robot Options (setScriptTimeout) timeout to : {}", session.getCerberus_selenium_setScriptTimeout_default());
-                driver.manage().timeouts().setScriptTimeout(session.getCerberus_selenium_setScriptTimeout_default(), TimeUnit.MILLISECONDS);
+                driver.manage().timeouts().setScriptTimeout(Duration.ofMillis(session.getCerberus_selenium_setScriptTimeout_default()));
                 session.setCerberus_selenium_setScriptTimeout(session.getCerberus_selenium_setScriptTimeout_default());
             }
             LOG.debug("Setting Robot highlightElement back to default values : Selenium {} Sikuli {}",
@@ -1396,7 +1395,7 @@ public void setOptionsToDefault(Session session) {
             if ((session.getAppiumDriver() != null) && (session.getCerberus_appium_wait_element() != session.getCerberus_appium_wait_element_default())) {
                 LOG.debug("Setting Appium Robot Options back to default timeout : {}", session.getCerberus_appium_wait_element_default());
                 AppiumDriver appiumDriver = session.getAppiumDriver();
-                appiumDriver.manage().timeouts().implicitlyWait(session.getCerberus_appium_wait_element_default(), TimeUnit.MILLISECONDS);
+                appiumDriver.manage().timeouts().implicitlyWait(Duration.ofMillis(session.getCerberus_appium_wait_element_default()));
             }
             session.setCerberus_appium_wait_element(session.getCerberus_appium_wait_element_default());