Don't assume user type on shares but resolve it each time #5
+137
−465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glpatcern
force-pushed
the
lwshares-fix
branch
from
d6d851e
to
5b49ee9
Compare
glpatcern
force-pushed
the
lwshares-fix
branch
from
5b49ee9
to
5eb0faa
Compare
|
Tested in QA |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR relates to cs3org/reva#4849
Prior to merge this, we need to ensure the Authorization (Grappa) API allows us to see the
activeUserfield.We may need some optimization here as every single share manipulation now costs a user lookup, which yes it's cached but still requires going out to the user provider and to Redis. An option is to store it in the db, next to
share_with.