This repository was archived by the owner on Feb 12, 2024. It is now read-only.
Fix for Growth Chart’s print functionality being extremely slow in IE.#15
Merged
shriniketsarkar-zz merged 1 commit intocerner/dstu2from Oct 31, 2017
Merged
Conversation
kpshek
approved these changes
Jun 21, 2017
|
+1 |
kolkheang
reviewed
Jul 12, 2017
| </div> | ||
| <div id="container"> | ||
| <div id="header"> | ||
| <h1 class="patient-name" data-translatecontent="STR_6021">Patient`s name</h1> |
Member
There was a problem hiding this comment.
The tick mark on Patients` is not the correct one.
Author
There was a problem hiding this comment.
This code was carried forward from the existing print window.
Checked with @kolkheang and wont be making any change for this as we want to retain whatever we can from the existing print functionality.
kolkheang
approved these changes
Jul 12, 2017
zplata
approved these changes
Aug 1, 2017
shriniketsarkar-zz
deleted the
GC_PrintingPopupSlownessIE_Fix_Issue_26
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue : The open source version of growth chart pops out a window for the print functionality. When the application is run in IE, launching the print window opens up the pop-up but the content is rendered extremely slow. This results in the user staring at a blank page for several seconds and sometimes minutes before any UI gets rendered on the screen. This gives the user an impression that the UI is stuck.
More Info on this Issue : smart-on-fhir#26
Fix : This PR fixes the slowness issue. The fix involves loading content on the popup window from the main growth chart window.
Changes :
**Printing Considerations : **
The user will need to print in landscape mode for Graph and Parent views where as portrait mode can be used for Table view.
@kpshek
@zplata
@mjhenkes
@kolkheang