More language cleanup (wip) #2609
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erve info from the original code when switching
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2609 +/- ##
============================================
- Coverage 65.08% 65.06% -0.03%
+ Complexity 2731 2723 -8
============================================
Files 278 277 -1
Lines 12128 12122 -6
============================================
- Hits 7894 7887 -7
- Misses 4234 4235 +1
|
Contributor
|
@chrieinv Should we remove this one? |
Contributor
Author
|
No, there are some changes that should be kept |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove class
LtiToH5PLanguageCleanup switching between locale code standards, try to preserve as much info as possible by using the original code