Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Helm chart OCI release to GH automation #340

Merged
merged 2 commits into from
Dec 18, 2024

Conversation

inteon
Copy link
Member

@inteon inteon commented Dec 11, 2024

Adds logic for pushing the Helm chart to an OCI registry (and adding a non-v-prefixed tag)

See cert-manager/makefile-modules#219 for more info.

@cert-manager-prow cert-manager-prow bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 11, 2024
@inteon inteon force-pushed the add_helm_oci_release branch 3 times, most recently from 6651e31 to 65f6b82 Compare December 11, 2024 19:46
@inteon inteon requested a review from wallrj December 13, 2024 13:30
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for also updating the RELEASE docs.

How does charts.jetstack.io get updated, if not by a PR?

/approve
/lgtm

Copy link
Member Author

@inteon inteon Dec 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not yet fully automated, but the initial automation is this: https://github.com/jetstack/jetstack-charts/pull/378
The goal is to run this automation periodically.

@cert-manager-prow cert-manager-prow bot added the lgtm Indicates that a PR is ready to be merged. label Dec 18, 2024
@cert-manager-prow
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wallrj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@cert-manager-prow
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wallrj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cert-manager-prow cert-manager-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 18, 2024
@inteon inteon force-pushed the add_helm_oci_release branch from 2b84a96 to 2147324 Compare December 18, 2024 12:32
@cert-manager-prow cert-manager-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Dec 18, 2024
@cert-manager-prow
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@inteon inteon added the lgtm Indicates that a PR is ready to be merged. label Dec 18, 2024
@inteon
Copy link
Member Author

inteon commented Dec 18, 2024

/hold

@cert-manager-prow cert-manager-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 18, 2024
Signed-off-by: Tim Ramlot <[email protected]>
@inteon inteon force-pushed the add_helm_oci_release branch from 2147324 to d9b7298 Compare December 18, 2024 12:35
@cert-manager-prow cert-manager-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Dec 18, 2024
@cert-manager-prow
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@inteon inteon added lgtm Indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Dec 18, 2024
@cert-manager-prow cert-manager-prow bot merged commit 834ec1c into cert-manager:main Dec 18, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants