-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make klone more atomic #8
Make klone more atomic #8
Conversation
…rors Signed-off-by: Tim Ramlot <[email protected]>
Signed-off-by: Tim Ramlot <[email protected]>
46e85aa
to
802636e
Compare
If the goal is to make it more atomic, how does syncing in place do that? It just means if it fails make will be broken in more subtle ways with files missing / half written. If its breaks now its obvious because the directory is empty, If we wanted to be atomic, we could leave the actual directories inside |
The following issues should be solved with this PR:
|
Ah, so its less about atomic changes, its more about reducing churn during sync. If thats the goal then this PR would solve it /lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: inteon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Don't remove full destination directory at start of sync, instead update the destination in place.