Make generated CRDs directly available for testing and development

[erikgb]

This is a new attempt at what was started in #209, but accidentally got merged before being fully reviewed (and then reverted in #213).

I think the CRDs generated by controller-gen should be available in our projects, not just temporary files used as input to Helm CRD templates. While this will semi-duplicate the CRDs in project repositories, I think it has a lot of benefits (not limited to):

• Making CRD manifests available in projects, and not just wrapped in a Helm chart.
• Avoid pitfalls such as https://github.com/cert-manager/trust-manager/blob/main/test/integration/bundle/integration.go#L41, which is a semi-blocker for running integration tests for IDEs.
• Possibly generate more resources using controller-gen. It can currently generate both webhook configuration resources and RBAC (roles and cluster roles).

I have suggested the default kubebuilder path for CRD manifests, even if we don't use/require kubebuilder in our projects. Open for other suggestions, but I think the term "bases" is important - as I think we can use kustomize to transform CRD in other use cases. When deciding on the path, please keep in mind that:

• We probably want to continue using the generated files as input to Helm chart templates.
• Leave room for possibly generating more than just CRDs.

[cert-manager-prow]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from erikgb. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ThatsMrTalbot]

Can you update the path to something like deploy/crds as discussed in the earlier thread, I also think we should drop a README in that dir with something like:

cert-manager recommends the CRDs are deployed as part of the Helm chart, these CRDs exist for reference and development.

After this merges we can create an github issue to refactor it out the helm module.

[erikgb]

Can you update the path to something like deploy/crds as discussed in the earlier thread, I also think we should drop a README in that dir with something like:

cert-manager recommends the CRDs are deployed as part of the Helm chart, these CRDs exist for reference and development.

After this merges we can create an github issue to refactor it out the helm module.

Will do! Thanks for reviewing @ThatsMrTalbot!

[erikgb]

@ThatsMrTalbot, your initial review comments should be addressed now. I have also created a WIP PR to verify/test that this would actually work in our projects: cert-manager/trust-manager#493. Rhere are probably additional (minor) details that need to be adjusted. PTAL!