refactor: move function for creating managed field entries #413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cert-manager-prow
bot
added
dco-signoff: yes
SgtCoDFish
approved these changes
Sep 10, 2024
cert-manager-prow
bot
added
lgtm
erikgb
force-pushed
the
managed-field-entries
branch
from
b270b8b to
dcaf560
Compare
cert-manager-prow
bot
removed
the
lgtm
Signed-off-by: Erik Godding Boye <[email protected]>
erikgb
force-pushed
the
managed-field-entries
branch
from
dcaf560 to
2239013
Compare
|
@SgtCoDFish I have now resolved the conflicts (and added a missing import alias). Could you take another look, please? :-) |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: SgtCoDFish The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #378 - which should show the motivation for this refactoring: I want to extract the code for handling configmap/secret targets out of the huge bundle package. The test utility function moved in this PR is used in tests that I want to move, but also in tests that should remain in the package.
If you think there is a better location (package) for this test utility code, please let me know.