Improve OpenAPI validation and SSA Golang markers #477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cert-manager-prow
bot
added
the
dco-signoff: yes
cert-manager-prow
bot
added
the
size/M
erikgb
commented
Nov 17, 2024
| @@ -59,6 +59,9 @@ type BundleList struct { | |||
| // BundleSpec defines the desired state of a Bundle. | |||
| type BundleSpec struct { | |||
| // Sources is a set of references to data whose data will sync to the target. | |||
| // +listType=atomic | |||
| // +kubebuilder:validation:MinItems=1 | |||
| // +kubebuilder:validation:MaxItems=100 | |||
There was a problem hiding this comment.
MaxItems is added to pass the cost requirements when CEL validations are added to the API.
inteon
reviewed
Nov 21, 2024
| @@ -67,6 +70,7 @@ type BundleSpec struct { | |||
|
|
|||
| // BundleSource is the set of sources whose data will be appended and synced to | |||
| // the BundleTarget in all Namespaces. | |||
| // +structType=atomic | |||
inteon
reviewed
Nov 21, 2024
inteon
reviewed
Nov 21, 2024
inteon
reviewed
Nov 21, 2024
Signed-off-by: Erik Godding Boye <[email protected]>
erikgb
force-pushed
the
enrich-api-spec
branch
from
63f265c
to
a25aa22
Compare
|
Great work, this is something that could be useful in our other APIs too. /approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: inteon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
cert-manager-prow
bot
added
the
approved
Yeah, I am going on a "round around the block". But I need static CRDs in Git first. 😉 |
inteon
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The proposed changes are extracted from #475. Before introducing CEL in the API specification, which will lift the K8s version requirements, I propose adding more "simple" validations to the API spec. Also adding processing instructions to API to ensure it will work smoothly for users using SSA.