WIP: Remove incomplete validation from webhook #478
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Erik Godding Boye <[email protected]>
cert-manager-prow
bot
added
the
dco-signoff: yes
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
cert-manager-prow
bot
added
the
size/M
inteon
reviewed
Nov 21, 2024
| if target := bundle.Spec.Target.ConfigMap; target != nil { | ||
| path := path.Child("sources") | ||
| for i, source := range bundle.Spec.Sources { | ||
| if source.ConfigMap != nil && source.ConfigMap.Name == bundle.Name && source.ConfigMap.Key == target.Key { |
There was a problem hiding this comment.
We don't just check that the keys match, we also check that the bundle name matches the source config map name.
There was a problem hiding this comment.
Thanks for pointing this out, @inteon. I will make an effort to fix the currently broken validation smarter.
erikgb
changed the title
cert-manager-prow
bot
added
the
do-not-merge/work-in-progress
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on #475, I noticed this validation that seems wrong to me, at least incomplete. Why shouldn't a user be allowed to use the same key in source and target? This will only become a potential problem if the "trust namespace" is included as a target namespace. And why would you do that? And after #460, this check is definitely incomplete - which means we have to find a better way to exclude sources as targets in the controller.