Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update trust-manager API docs #1580

Merged

Conversation

erikgb
Copy link
Contributor

@erikgb erikgb commented Oct 5, 2024

After some refactoring of the CRD handling in trust-manager, the script to generate trust-manager API docs seems broken. This PR applies a quick fix to the generate-script and regenerates the trust-manager API docs.

Some upstream K8s godocs copied into the Bundle CRD is rendering invalid HTML and needs to be "escaped"/replaced.

Reported in cert-manager/trust-manager#428.

@cert-manager-prow cert-manager-prow bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 5, 2024
@erikgb erikgb force-pushed the update-trust-manager-api-docs branch 3 times, most recently from 71ee032 to 5ec8381 Compare October 5, 2024 17:29
@cert-manager-prow cert-manager-prow bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 5, 2024
Copy link

netlify bot commented Oct 5, 2024

Deploy Preview for cert-manager ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 978b207
🔍 Latest deploy log https://app.netlify.com/sites/cert-manager/deploys/67018299b5af1900084b5fc4
😎 Deploy Preview https://deploy-preview-1580--cert-manager.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@erikgb erikgb force-pushed the update-trust-manager-api-docs branch from b1228ee to 5ec8381 Compare October 5, 2024 17:47
Signed-off-by: Erik Godding Boye <[email protected]>
@erikgb erikgb force-pushed the update-trust-manager-api-docs branch from 5ec8381 to 978b207 Compare October 5, 2024 18:16
Copy link
Member

@SgtCoDFish SgtCoDFish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Thanks!

@cert-manager-prow cert-manager-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 8, 2024
@cert-manager-prow
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SgtCoDFish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cert-manager-prow cert-manager-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 8, 2024
@cert-manager-prow cert-manager-prow bot merged commit b7c87fd into cert-manager:master Oct 8, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants