Can we change it to check for empty "" instead of None. Shadowserver api collector.

[sarabesh]

intelmq/intelmq/bots/collectors/shadowserver/collector_reports_api.py

Line 112 in 42a9bfa

if self.types is not None:

By default from the intelmq, types is added as "", when we leave it empty though all the JSON conversions. So, I had some time to figure out why my reports were being filtered. Eventually, as a temporary work around I removed the types parameter completely.

[kamil-certat]

Looks like it should be just if not self.types

[sebix]

Yes, that's clearly a bug

[elsif2]

I believe it should be if self.types.

[elsif2]

All the other parameters are tested with is None so I don't see why types is handled differently.

[sebix]

Depends on what you check for. If "", False and None should be treated equally, use if self.types, otherwise check for the value explicitly.
"" usually appears when a bot is edited with the manager and should always be handled.