Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle empty parameters correctly. #2481

Conversation

elsif2
Copy link
Collaborator

@elsif2 elsif2 commented Mar 18, 2024

Update to intelmq/bots/collectors/shadowserver/collector_reports_api.py to handle empty parameters correctly as reported in #2477.

@sebix sebix added component: bots bug Indicates an unexpected problem or unintended behavior labels Mar 18, 2024
@sebix sebix added this to the 3.3.1 milestone Mar 18, 2024
@sebix sebix merged commit d58dba0 into develop Mar 18, 2024
31 checks passed
@sebix sebix deleted the 2477-can-we-change-it-to-check-for-empty-instead-of-none-shadowserver-api-collector branch March 18, 2024 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Indicates an unexpected problem or unintended behavior component: bots
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can we change it to check for empty "" instead of None. Shadowserver api collector.
2 participants