FIX: intelmqsetup - never take ownership of / #2355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tool intelmqsetup wants to change the owner ROOT_DIR path. If instructed to install IntelMQ in LSB-style paths, it's set to the '/' resulting in changing the owner of system root to intelmq. This case is rare to happen (requires explixitly set INTELMQ_PATHS_NO_OPT variable and using PIP package or directly the source code, as the native package doesn't contain intelmqsetup), but it's still potentially dangerous and can cause the system degradation (e.g. prevents systemd-tmpfiles from working correctly). Fixes: certtools#2354
sebix
added
bug
sebix
requested changes
May 3, 2023
Co-authored-by: Sebastian <[email protected]>
|
@sebix Do you have any questions more, or we could merge it? |
sebix
approved these changes
May 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tool intelmqsetup wants to change the owner ROOT_DIR path.
If instructed to install IntelMQ in LSB-style paths, it's set
to the '/' resulting in changing the owner of system root to
intelmq.
This case is rare to happen (requires explixitly set INTELMQ_PATHS_NO_OPT
variable and using PIP package or directly the source code,
as the native package doesn't contain intelmqsetup), but it's
still potentially dangerous and can cause the system degradation
(e.g. prevents systemd-tmpfiles from working correctly).
Fixes: #2354