FIX: Let modified_pulses_only can be changed #2449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original logic will cause modified_pulses_only is always False.
|
Hey, thanks for catching that! Could you please add an entry to the Changelog.md with your fix? A test would be also great, but I think it had to be about the whole feature, so I believe we can go without it eventually. |
kamil-certat
added
bug
|
reviewed. Clear logic bug, thx for catching it @qux-bbb . Pulling that in. |
|
@sebix could you please also double check? It's trivial . thx. if all ok, pls press "merge" :) thx |
kamil-certat
reviewed
Feb 1, 2024
kamil-certat
approved these changes
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original logic will cause modified_pulses_only is always False.