FIX: RIPE expert: handle unknown response for non-ASN types #2461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, it looks good to me!. Do you think it would be possible to easily add a test for that case? And a short changelog entry? |
Certainly. |
|
Thank you, @monoidic |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the RIPE bot successfully handles "No abuse contact found for" messages in response to ASNs, but not for IPs. An example of this would be the address
2001:470:1:c84::12e, which is from a range assigned by ARIN.This PR removes the filter on only checking for these types of messages on ASNs, allowing for IPs to not cause errors in the bot.