FIX: handle init failure on incorrect current event #2494
Conversation
If event hold in current event wasn't saved correctly, the bot is unable to start and handle any event.
| self.min_time_current = last_min_time | ||
| self.max_time_current = last_max_time | ||
| except: | ||
| self.logger.exception("Loading current event %s failed. Skipping it.", self.current_event) |
There was a problem hiding this comment.
Is it really OK to drop events if there was a failure?
There was a problem hiding this comment.
It's not dropping anything, as long as I didn't missed anything. This bot is making a new MISP event periodically, and writing incoming IntelMQ events in the same event. Every time they are saved to the file with the MISP event. The current_event is just a reference to the current MISP event, and if we don't load the current (actually: the last one created), the bot creates a new one and save data there. Old data, if they exist, are not lost.
In my case, the pointer to the current MISP event was pointing to not-existing file. When I still need to understand why, as long as we don't have atomic saving to the disk, it may happen (e.g. crash between saving the pointer file and the actual event file)
If event hold in current event wasn't saved correctly, the bot is unable to start and handle any event.
In our case, the file wasn't created at all. I'm not sure yet why (I suspect some trouble by reloading), but such a problem shouldn't stop the bot from working.