Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the auto_update parameter to the docs. #2503

Merged

Conversation

elsif2
Copy link
Collaborator

@elsif2 elsif2 commented Jun 26, 2024

Minor update to the shadowserver parser documentation.

@elsif2 elsif2 linked an issue Jun 26, 2024 that may be closed by this pull request
@elsif2
Copy link
Collaborator Author

elsif2 commented Jun 26, 2024

@sebix All unit tests failed with:

=========================== short test summary info ============================
FAILED intelmq/tests/bots/experts/ripe/test_expert.py::TestRIPEExpertBot::test_db_ipv4_lookup - AssertionError: {'__type': 'Event', 'source.ip': '93.184.21[170 chars]5492} != {'source.ip': '93.184.216.34', 'destination[153 chars]ent'}
  {'__type': 'Event',
   'destination.abuse_contact': '[email protected]',
   'destination.asn': 35492,
   'destination.ip': '193.238.157.5',
-  'source.abuse_contact': '[email protected]',
?                                 ---------------   --- -

+  'source.abuse_contact': '[email protected]',
?                                   ++

   'source.ip': '93.184.216.34'}
====== 1 failed, 1118 passed, 42 skipped, 4 xfailed in 154.06s (0:02:34) =======

@sebix
Copy link
Member

sebix commented Jun 26, 2024

@sebix All unit tests failed with:

Fix will come with #2504

@sebix sebix self-assigned this Jun 26, 2024
@sebix sebix added bug Indicates an unexpected problem or unintended behavior documentation Indicates a need for improvements or additions to documentation labels Jun 26, 2024
@sebix sebix added this to the 3.3.1 milestone Jun 26, 2024
@sebix sebix merged commit 3375b61 into develop Jun 26, 2024
31 checks passed
@sebix sebix deleted the 2502-shadowserver-parser-missing-documentation-on-auto_update branch June 26, 2024 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Indicates an unexpected problem or unintended behavior documentation Indicates a need for improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shadowserver parser: missing documentation on auto_update
2 participants