-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable default module.ceylon (review only) #1022
base: master
Are you sure you want to change the base?
Conversation
CC #200, the |
@lucaswerkmeister This is just so you can add a |
Right, for a script this needs to be allowed in a regular CU (not the three kinds of CU we have today). |
@lucaswerkmeister Yes, it is. I have followed #200 before, but I think it is logical, as the word 'default' should not be in the user vocabulary, but implied, in order to keep the folder structure in sync with the naming. So, souce root = no folder name = no module name = no package name -- as far as the user is concerned. Running it needs 'default'. @gavinking Does the grammar look OK?, as that will drive the code and testing. As the language allows multiple type declarations in a source file, is the need for both |
I dunno, I'm not totally convinced that we shouldn't make them write |
Writing |
@gavinking we never decided what to do with this and has been sitting here for a long time. Don't you think this could be worthwhile? |
This pull request is just for review and discussion. Default module with name "default" with package "" seems to compile and run fine, with no detrimental effect on existing compilation or compilation of default module without module.ceylon:
Although the compilers compiles the default module with module.ceylon and package.ceylon fine without imports, it does not add dependencies to the module annotation, although they are present in the typechecker. Some additional errors are also thrown.