Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added photo thumbnails to tweets with entities #424

Open
wants to merge 41 commits into
base: master
Choose a base branch
from

Conversation

rsvargas
Copy link
Contributor

Added an option to show a small preview of photos identified by the entities object. Kinda like Twitter's new interface.

@kav2k
Copy link

kav2k commented Dec 6, 2014

@rsvargas I'm making a fork of Silver Bird, since it is no longer maintained. Would you mind if I include your patch?

@rsvargas
Copy link
Contributor Author

rsvargas commented Dec 9, 2014

Of course I don't mind, feel free to add these. I'll be glad!

@theDraco
Copy link

@kav2k: Do you plan to make it public? What will the name be? Can you make the "mute" and "block" features work? Right now if you block or mute someone, their tweets still show up in Silverbird.

@rsvargas: How do I get this to work? I have copied all 10 files you changed into the 1.9.10.2 Silverbird folder, but when I'm done it says the extension is corrupted. I have done it 3 times now, what am I doing wrong? I'm trying to get images to display in the Silverbird window.

@kav2k
Copy link

kav2k commented Dec 12, 2014

@theDraco It's up at https://github.com/kav2k/silver_feather
I changed the name to Silver Feather to avoid confusion. It's currently published to the Web Store but it unlisted (not searchable) until I straighten up more pressing problems. You can install it already as some important fixes are already in.

You can't just replace files of a packed extension, Chrome will block that. You need to download the whole thing and load it as unpacked in developer mode.

@theDraco
Copy link

@kav2k Great, I got it working. A couple questions. Is it possible to get the "mute" and "blocked" functions working in Silverbird? Right now if you mute someone their tweets still show up in Silverbird. The same if you block them.

And one more thing, is it possible to make the image previews full size? Right now if you hover over an image link the preview is very tiny, can I make it bigger?

@kav2k
Copy link

kav2k commented Dec 13, 2014

@theDraco I think I'm going to implement larger previews, but it's not high priority. Feel free to add bugs about that and mute/blocked on my issue tracker so I don't forget about it.

@rsvargas
Copy link
Contributor Author

@theDraco I'll probably rewrite this as a pull request do @kav2k 's new fork in a few days. So is probably best to wait for that.

If you still want to get this before and you are having problems with the merge, you can try to checkout this branch from my fork: https://github.com/rsvargas/silver_bird/tree/photo-thumbnails

Still needs layout fixes before closing
@kav2k
Copy link

kav2k commented Dec 15, 2014

@rsvargas I'm not that eager to merge this in right away; I haven't tested it yet and it's kind of a low priority compared to a lot of other issues. I'd still be happy if you make a pull request - just don't expect it to be merged very fast.

kav2k and others added 20 commits December 21, 2014 02:01
…ge_feather

Conflicts:
	lib/tweet_manager.js
	lib/tweets_assembler.js
Comments:
Line 57 //Sjednocený = singular; this is plural
Line 78 // hledání -frequent
Line 81 // od (person); z (place)
Line 87 //sent to user - odesláno uživateli
Line 114  //Odpověď - noun; Odpověďet - verb
Line 117  //verb: Retweetnout
Line 370  //1 minuta, 2 minuty, 3 minuty, 4 minuty, 5 minuty, 6 minuty, 7 minut ...
Line 387  //same as minutes
Line 402  // we do not use X years ago. we use 'před X lety' - something like before X years
Line 441  //Where? Nahoře
Line 444  //Where? Dole
Including: custom color, auto-expand
… merge_feather

Conflicts:
	css/options.css
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants