Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENT-11923: Fixed bug in double expansion of foreign list variables with namespaces #5564

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

larsewi
Copy link
Contributor

@larsewi larsewi commented Jul 3, 2024

Prior to fix, the added acceptance test had the following output:

R: /home/larsewi/ntech/cfengine/core/tests/acceptance/01_vars/01_basic/double_expansion_list_namespace.cf FAIL
R: $($(parent_namespace):$(parent_bundle).str) => EXPANDED
R: $($(parent_namespace):$(parent_bundle).lst) => $(bogus:check.lst)
R: $(default:check.lst)                        => EXPANDED

Ticket: ENT-11923
Changelog: Title
Signed-off-by: Lars Erik Wik [email protected]

Build Status

Back-ported to #5565

@larsewi larsewi force-pushed the messiah branch 2 times, most recently from 2576143 to 124f26a Compare July 3, 2024 17:01
@larsewi larsewi changed the title messiah ENT-11923: Fixed bug in double expansion of foreign list variables with namespaces Jul 3, 2024
libpromises/iteration.c Fixed Show fixed Hide fixed
libpromises/iteration.c Fixed Show fixed Hide fixed
libpromises/iteration.c Fixed Show fixed Hide fixed
@larsewi larsewi force-pushed the messiah branch 3 times, most recently from fc2e2e6 to 7532a97 Compare July 5, 2024 14:23
Copy link
Contributor

@vpodzime vpodzime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me otherwise. Well done, sir! 👏

libpromises/iteration.c Outdated Show resolved Hide resolved
libpromises/iteration.c Outdated Show resolved Hide resolved
Prior to fix, the added acceptance test had the following output:

```
R: /home/larsewi/ntech/cfengine/core/tests/acceptance/01_vars/01_basic/double_expansion_list_namespace.cf FAIL
R: $($(parent_namespace):$(parent_bundle).str) => EXPANDED
R: $($(parent_namespace):$(parent_bundle).lst) => $(bogus:check.lst)
R: $(default:check.lst)                        => EXPANDED
```

Ticket: ENT-11923
Changelog: Title
Signed-off-by: Lars Erik Wik <[email protected]>
Copy link
Contributor

@vpodzime vpodzime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@larsewi larsewi added the cherry-pick? Fixes which may need to be cherry-picked to LTS branches label Jul 8, 2024
@larsewi larsewi removed the cherry-pick? Fixes which may need to be cherry-picked to LTS branches label Jul 8, 2024
@larsewi larsewi merged commit 315bf3f into cfengine:master Jul 8, 2024
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants