Adjusted valgrind-check Containerfile to ensure apt update and install are linked and cached together in one layer (3.21) #5911
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
craigcomstock
changed the title
…l are linked and cached together in one layer Otherwise, the update layer can be cached and have bad information for the subsequent two install command layers. As the distribution changes package versions the install layers, if they are not cached, will fail. Also combined the two install commands into one for brevity. Ticket: ENT-13252 Changelog: none (cherry picked from commit c6e385d) Conflicts: tests/valgrind-check/Containerfile To get a smaller change I just combined the update and install apt lines instead of also changing the ubuntu version and package list.
craigcomstock
force-pushed
the
ENT-13252/3.21
branch
from
a14a257 to
ff1c167
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise, the update layer can be cached and have bad information for the subsequent two install command layers.
As the distribution changes package versions the install layers, if they are not cached, will fail.
Also combined the two install commands into one for brevity.
Ticket: ENT-13252
Changelog: none
(cherry picked from commit c6e385d)
Conflicts:
tests/valgrind-check/Containerfile
To get a smaller change I just combined the update and install apt lines instead of also changing the ubuntu version and package list.