Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CFE-3866: Added test that set_variable_values_ini does not error when keys are not present in promised section #2141

Open
wants to merge 16 commits into
base: master
Choose a base branch
from
Open

CFE-3866: Added test that set_variable_values_ini does not error when keys are not present in promised section #2141

wants to merge 16 commits into from

Commits on Nov 11, 2021

  1. Added test that set_variable_values_ini does not error when keys are … 

    …not present in promised section

Ticket: CFE-3866
Changelog: None
    @nickanderson
    nickanderson committed Nov 11, 2021
    Configuration menu
    Copy the full SHA
    28d6187 View commit details
    Browse the repository at this point in the history

  2. Avoided trying to set field before resolving section presence 

    Previously set_variable_values_ini would try to resolve field_edits before first
ensuring that the section of the ini being promised was resolved. This results
in errors when there are no fields to edit. This change uses bundle scoped
classes to guard field_edits from actuating until after the promise ensuring the
section itself exists has been reached, effectively preventing the errors from
being emitted.

Ticket: CFE-3867
Changelog: Commit
    @nickanderson
    nickanderson committed Nov 11, 2021
    Configuration menu
    Copy the full SHA
    af36b6b View commit details
    Browse the repository at this point in the history

  3. Tweak

    @nickanderson
    nickanderson committed Nov 11, 2021
    Configuration menu
    Copy the full SHA
    08bc594 View commit details
    Browse the repository at this point in the history

  4. canonify when checking if section reached 

    section can include characters that are not valid classes are canonified
automatically on definition, but we gotta do that for checking
    @nickanderson
    nickanderson committed Nov 11, 2021
    Configuration menu
    Copy the full SHA
    1705381 View commit details
    Browse the repository at this point in the history

  5. Avoid promising 2 sections in the test

    @nickanderson
    nickanderson committed Nov 11, 2021
    Configuration menu
    Copy the full SHA
    7264aba View commit details
    Browse the repository at this point in the history

  6. tweak test

    @nickanderson
    nickanderson committed Nov 11, 2021
    Configuration menu
    Copy the full SHA
    6b862f5 View commit details
    Browse the repository at this point in the history

  7. restore classes already in use

    @nickanderson
    nickanderson committed Nov 11, 2021
    Configuration menu
    Copy the full SHA
    f5dc8ba View commit details
    Browse the repository at this point in the history

  8. restore previous indentation for promise attr

    @nickanderson
    nickanderson committed Nov 11, 2021
    Configuration menu
    Copy the full SHA
    f25bfb0 View commit details
    Browse the repository at this point in the history

  9. use the right variable for section name!

    @nickanderson
    nickanderson committed Nov 11, 2021
    Configuration menu
    Copy the full SHA
    0271fb4 View commit details
    Browse the repository at this point in the history

  10. disabled uncomment support, removed unused class conditions

    @nickanderson
    nickanderson committed Nov 11, 2021
    Configuration menu
    Copy the full SHA
    7aa0d74 View commit details
    Browse the repository at this point in the history

Commits on Nov 12, 2021

  1. ?

    @nickanderson
    nickanderson committed Nov 12, 2021
    Configuration menu
    Copy the full SHA
    7c8413a View commit details
    Browse the repository at this point in the history

  2. ?

    @nickanderson
    nickanderson committed Nov 12, 2021
    Configuration menu
    Copy the full SHA
    a75ccb7 View commit details
    Browse the repository at this point in the history

  3. moms spagetti

    @nickanderson
    nickanderson committed Nov 12, 2021
    Configuration menu
    Copy the full SHA
    3204dbc View commit details
    Browse the repository at this point in the history

  4. ml generated regex ftw?

    @nickanderson
    nickanderson committed Nov 12, 2021
    Configuration menu
    Copy the full SHA
    d1a2cd7 View commit details
    Browse the repository at this point in the history

  5. craigs spagetti

    @nickanderson
    nickanderson committed Nov 12, 2021
    Configuration menu
    Copy the full SHA
    e80af28 View commit details
    Browse the repository at this point in the history

  6. pre-escape

    @nickanderson
    nickanderson committed Nov 12, 2021
    Configuration menu
    Copy the full SHA
    4c86690 View commit details
    Browse the repository at this point in the history