Add ESLint typescript resolver to fix exports issue #2133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ESLint's import plugin doesn't support package.json `exports` definitions out of the box. There's a longstanding issue to fix it but the recommendation is to use the eslint typescript resolver that solves the problem. This repo doesn't use typescript but adding the resolver with zero configuration fixes things and adds minimal bloat. See import-js/eslint-plugin-import#1810 See https://github.com/import-js/eslint-import-resolver-typescript
✅ Thanks for the improvements! Browse a preview of your changes using the link below.
To edit notification comments on pull requests, go to your Netlify site configuration. |
anselmbradford
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ESLint's import plugin doesn't support package.json
exportsdefinitionsout of the box. There's a longstanding issue to fix it but the recommendation
is to use the ESLint typescript resolver that solves the problem. This repo
doesn't use typescript but adding the resolver with zero configuration
fixes things and adds minimal bloat.
Testing
yarn lintshould now pass without errorsChecklist
Testing checklist
Browsers
Accessibility
Other