Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Eich regression 9 #114

Merged
merged 7 commits into from
Oct 16, 2024
Merged

Add Eich regression 9 #114

merged 7 commits into from
Oct 16, 2024

Conversation

tbody-cfs
Copy link
Collaborator

Add lambda-q regression 9 from Eich et al, 2013

@tbody-cfs tbody-cfs requested a review from hassec October 4, 2024 20:57
hassec
hassec requested changes Oct 7, 2024
View reviewed changes
Copy link
Collaborator

@hassec hassec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some questions and would you mind double checking the CI tests? There seem to be some failures.

cfspopcon/formulas/scrape_off_layer/lambda_q.py Outdated Show resolved Hide resolved
cfspopcon/formulas/scrape_off_layer/lambda_q.py Show resolved Hide resolved
cfspopcon/formulas/scrape_off_layer/lambda_q.py Show resolved Hide resolved
@tbody-cfs tbody-cfs mentioned this pull request Oct 9, 2024
Closed
hassec
hassec requested changes Oct 16, 2024
View reviewed changes
Copy link
Collaborator

@hassec hassec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
Apologies for the lat request, but any chance you can add a tiny test for the Eich 9 variant, just to make sure it's run at least once in the tests?

@tbody-cfs tbody-cfs requested a review from hassec October 16, 2024 12:48
@hassec hassec merged commit 8e88cc6 into main Oct 16, 2024
8 checks passed
@hassec hassec deleted the eich_regression_9 branch October 16, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hassec hassec hassec approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tbody-cfs @hassec