Separatrix operational space #12
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbody-cfs
force-pushed
the
separatrix_operational_space
branch
2 times, most recently
from
9babfa0 to
d280364
Compare
tbody-cfs
force-pushed
the
separatrix_operational_space
branch
from
d280364 to
e380774
Compare
tbody-cfs
force-pushed
the
separatrix_operational_space
branch
from
e380774 to
2f8c82d
Compare
hassec
requested changes
Jan 24, 2024
| ) | ||
| alpha_c = calc_critical_MHD_parameter_alpha_c(elongation=elongation_psi95, triangularity=triangularity_psi95) | ||
|
|
||
| poloidal_circumference = 2.0 * np.pi * minor_radius * (1 + 0.55 * (elongation_psi95 - 1)) * (1 + 0.08 * triangularity_psi95**2) |
There was a problem hiding this comment.
Where does this formula come from? And why is it different compared to the poloidal_circumference in separatrix_operational_space.auxillaries.poloidal circumference ?
cfspopcon/formulas/separatrix_operational_space/LH_transition_condition_func.py
Show resolved
Hide resolved
cfspopcon/formulas/separatrix_operational_space/LH_transition_condition_func.py
Show resolved
Hide resolved
cfspopcon/formulas/separatrix_operational_space/MHD_limit_condition_func.py
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the model from https://iopscience.iop.org/article/10.1088/1741-4326/ac0412
[x] Adds an example case corresponding to the paper
[x] Adds a notebook demonstrating how to use
[x] Adds unit tests and increases coverage
[x] Verify that results match implementation in paper
[x] Adds new variables to physics glossary