-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unit handling and round-trip .nc conversion fixes #13
Conversation
Closes #10 |
Think I've figured out how to reproduce the error. To fix https://github.com/cfs-energy/cfspopcon/actions/runs/7038938605/job/19156931593?pr=7, I added
|
And then I fixed it again https://github.com/cfs-energy/cfspopcon/actions/runs/7039432837/job/19158407447?pr=13 🥳🥳🥳 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a small change request to add a comment to the conversion logic.
I'd prefer to have dependency updates to the poetry.lock
in a separate PR but since you already fixed the mypy stuff here let's merge this as is. But in the future we should try and avoid poetry updates in PRs that have other changes.
Co-authored-by: Christoph Hasse <[email protected]>
No description provided.