Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement model to calculate edge impurity concentration #7

Merged
merged 16 commits into from
Feb 28, 2024

Conversation

tbody-cfs
Copy link
Collaborator

@tbody-cfs tbody-cfs commented Nov 16, 2023

This merge request adds in the "Lengyel model", as described in

Nucl. Fusion 61 (2021) 046029 (21pp) https://doi.org/10.1088/1741-4326/abe4b2
"Comparison between SOLPS-4.3 and the Lengyel Model for ITER baseline neon-seeded plasmas"
D. Moulton, P.C. Stangeby, X. Bonnin and R.A. Pitts

The Lengyel model was originally presented in a 1981 IPP report "Analysis of Radiating Plasma Boundary Layers" by L. L. Lengyel, report number 1/191

The model gives the concentration of a radiating impurity required to achieve a requested radiative power dissipation fraction in the SOL. Usually, the calculated concentration can be related to the concentration from a higher-fidelity model such as SOLPS (see Moulton paper) via a constant factor, which we call the lengyel_overestimation_factor.

@tbody-cfs tbody-cfs changed the title Draft: Implement model to calculate edge impurity concentration Implement model to calculate edge impurity concentration Nov 30, 2023
@tbody-cfs tbody-cfs force-pushed the lengyel_model branch 5 times, most recently from 5538f1f to 3e92cdd Compare December 4, 2023 20:46
@tbody-cfs
Copy link
Collaborator Author

For the variables previously killing the pipeline, this shows the absolute difference (ref - test) and relative difference (1 - ref/test). rtol of 1e-5 (default for xr.testing.assert_allclose is large enough that the test passes, while 1E-6 doesn't. Still don't have a good idea why these differences are here, but they might be related to machine architecture
image
image
image

.github/workflows/workflow_actions.yml Outdated Show resolved Hide resolved
cfspopcon/algorithms/__init__.py Show resolved Hide resolved
example_cases/SPARC_PRD/input.yaml Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
@tbody-cfs tbody-cfs merged commit 2bf0795 into cfs-energy:main Feb 28, 2024
7 checks passed
@nelsonand
Copy link
Contributor

@tbody-cfs What is the extent of this update? Does it help already to solve https://github.com/cfs-energy-internal/POPSIM/issues/28?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants