This repository was archived by the owner on Sep 7, 2022. It is now read-only.
Fix issue where non-existing thumbs are created.#9
Open
GCheung55 wants to merge 1 commit intocfx:masterfrom
Open
Fix issue where non-existing thumbs are created.#9GCheung55 wants to merge 1 commit intocfx:masterfrom
GCheung55 wants to merge 1 commit intocfx:masterfrom
Conversation
`_V_.Playlist` createElement has an issue where it's looping through the `videos` property to create the thumbs, but it's using a for-in loop without a check for hasOwnProperty, which just makes a thumb for every property in the `videos` prototype chain.
|
I am not able to see thumbs automatically created. Is that a feature? |
|
Added the auto-play feature: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_V_.PlaylistcreateElement has an issue where it's looping through thevideosproperty to create the thumbs, but it's using a for-in loop without a check for hasOwnProperty, which just makes a thumb for every property in thevideosprototype chain.