-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed ImGui modifier keys (again) #173
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ImGui mod keys (like Ctrl-clicking on a slider to enter a value manually) did not work anymore. This presumably happened during the big ImGui update in commit b15af18.
…splay's content scale through GLFW
johannesugb
force-pushed
the
ac_fix_imgui_modkeys
branch
from
October 10, 2023 11:46
08cc6a6
to
1393316
Compare
ImGui mod keys (like Ctrl-clicking on a slider to enter a value manually) did not work anymore. This presumably happened during the big ImGui update in commit b15af18.
…splay's content scale through GLFW
johannesugb
force-pushed
the
ac_fix_imgui_modkeys
branch
from
October 15, 2023 08:13
d87438c
to
c61b226
Compare
…0f (using ImGui's default font otherwise)
Added `aAlterSettingsBeforeCreation` to the imgui_manager constructor for changing to an arbitrary style. Also added `set_custom_font_mode` to influence whether the new font is used.
Whoops^2
# Conflicts: # auto_vk_toolkit/src/JetBrainsMono-Regular.cpp # auto_vk_toolkit/src/imgui_manager.cpp
fmt::format caused all kinds of deprecation warnings/errors with the latest MSVC. # Conflicts: # auto_vk_toolkit/src/imgui_manager.cpp
johannesugb
force-pushed
the
ac_fix_imgui_modkeys
branch
from
December 1, 2023 10:33
615d11d
to
503e77d
Compare
johannesugb
approved these changes
Dec 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ImGui mod keys (like Ctrl-clicking on a slider to enter a value manually) did not work anymore. This presumably happened during the big ImGui update in commit b15af18.