Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed ImGui modifier keys (again) #173

Merged
merged 27 commits into from
Dec 6, 2023
Merged

Conversation

alexc71
Copy link
Collaborator

@alexc71 alexc71 commented Oct 4, 2023

ImGui mod keys (like Ctrl-clicking on a slider to enter a value manually) did not work anymore. This presumably happened during the big ImGui update in commit b15af18.

alexc71 and others added 4 commits October 9, 2023 19:47
ImGui mod keys (like Ctrl-clicking on a slider to enter a value manually) did not work anymore.
This presumably happened during the big ImGui update in commit b15af18.
@johannesugb johannesugb changed the base branch from master to development October 10, 2023 11:58
johannesugb and others added 12 commits October 15, 2023 10:41
Added `aAlterSettingsBeforeCreation` to the imgui_manager constructor
for changing to an arbitrary style.
Also added `set_custom_font_mode` to influence whether the new font is
used.
# Conflicts:
#	auto_vk_toolkit/src/JetBrainsMono-Regular.cpp
#	auto_vk_toolkit/src/imgui_manager.cpp
fmt::format caused all kinds of deprecation warnings/errors with the latest MSVC.

# Conflicts:
#	auto_vk_toolkit/src/imgui_manager.cpp
Copy link
Member

@johannesugb johannesugb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@johannesugb johannesugb merged commit 6991a70 into development Dec 6, 2023
12 checks passed
@johannesugb johannesugb deleted the ac_fix_imgui_modkeys branch December 6, 2023 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants