Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add aggregation type support #4

Open
wants to merge 20 commits into
base: master
Choose a base branch
from

Commits on Oct 17, 2011

  1. update should be updateMany in second example.

    added "../lib" path to requiring buffer_ieee754, was breaking otherwise.
    christopher holt committed Oct 17, 2011
    Configuration menu
    Copy the full SHA
    0e006ad View commit details
    Browse the repository at this point in the history
  2. gitignore

    christopher holt committed Oct 17, 2011
    Configuration menu
    Copy the full SHA
    9ef9c84 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    8da4c7e View commit details
    Browse the repository at this point in the history
  4. updated tests

    christopher holt committed Oct 17, 2011
    Configuration menu
    Copy the full SHA
    56bc907 View commit details
    Browse the repository at this point in the history
  5. styling

    christopher holt committed Oct 17, 2011
    Configuration menu
    Copy the full SHA
    fe0805e View commit details
    Browse the repository at this point in the history
  6. copied propagateLowerArchives from updateManyArchive to update [compl…

    …ete hack, but works]
    christopher holt committed Oct 17, 2011
    Configuration menu
    Copy the full SHA
    645c674 View commit details
    Browse the repository at this point in the history
  7. hitting a race condition with reading from the buffer - "Error: Offse…

    …t is out of bounds"
    
    try/catch on all fs.read handles this, but does not solve it.
    christopher holt committed Oct 17, 2011
    Configuration menu
    Copy the full SHA
    e773735 View commit details
    Browse the repository at this point in the history
  8. horrible implementation of last, works but needs optimization.

    christopher holt committed Oct 17, 2011
    Configuration menu
    Copy the full SHA
    989e3c0 View commit details
    Browse the repository at this point in the history
  9. specify time at

    christopher holt committed Oct 17, 2011
    Configuration menu
    Copy the full SHA
    ea2181b View commit details
    Browse the repository at this point in the history
  10. Revert "specify time at"

    This reverts commit ea2181b.
    christopher holt committed Oct 17, 2011
    Configuration menu
    Copy the full SHA
    879972d View commit details
    Browse the repository at this point in the history
  11. Revert e773735^..HEAD

    christopher holt committed Oct 17, 2011
    Configuration menu
    Copy the full SHA
    9c2dfd8 View commit details
    Browse the repository at this point in the history
  12. one too many reverts, added try/catch for error handling out of bound…

    …s offsets on fs.read
    christopher holt committed Oct 17, 2011
    Configuration menu
    Copy the full SHA
    05171df View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2011

  1. fix sort method, was not setting maxRetention properly

    christopher holt committed Oct 21, 2011
    Configuration menu
    Copy the full SHA
    c39b7a4 View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2011

  1. pass errors back through to callback

    christopher holt committed Oct 24, 2011
    Configuration menu
    Copy the full SHA
    060a54e View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2012

  1. Fixes ignoring of XFilesFactor

    The XFilesFactor that was being passed to the create method
    was being ignored previously.  Now it isn't.
    
    Signed-off-by: ciaranj <[email protected]>
    ciaranj committed Oct 15, 2012
    Configuration menu
    Copy the full SHA
    0e0bdb6 View commit details
    Browse the repository at this point in the history
  2. Fixes updateMany so it now, err, updates many!

    Previously calls to updateMany would ultimately have their
    data discarded, as concat does not mutate the existing
    arrays but returns a new one, the python-ported algorithm
    doesn't quite apply.
    
    Signed-off-by: ciaranj <[email protected]>
    ciaranj committed Oct 15, 2012
    Configuration menu
    Copy the full SHA
    3ab6edb View commit details
    Browse the repository at this point in the history
  3. unixTime() will now round up, rather than down.

    This change may be un-acceptable :(.  If Hoard.js is used within the same
    process as statsd (as for example a back-end) then it is possible that hoard
    will refuse updates from statsD's flush event as the timestamp that
    statsd generates will appear to be from the future.
    
    This is because Hoard.js was using:
    
      parseInt( new Date().getTime() / 1000 )
    
    But statsd is using :
    
      Math.round( new Date().getTime() / 1000 )
    
    To get their idea of 'now'.  Most of the time this will be ok, but if
    a the result of the division contains a fractional part greater than or
    equal to .5 then statsd will round-up to the next nearest integer value
    but Hoard was truncating (discarding?) the fractional part, meaning
    it would be (as far as it was concerned) timestamps from the future
    when update was called sufficiently quickly after the flush.
    
    Signed-off-by: ciaranj <[email protected]>
    ciaranj committed Oct 15, 2012
    Configuration menu
    Copy the full SHA
    3c8b006 View commit details
    Browse the repository at this point in the history
  4. Adds configurable aggregationType support

    Much like commit 0cc664 in the python whisper project,
    this commit introduces support for specifying the aggregation type
    (one of 'sum', 'max', 'min', 'last' or 'average') when propagating
    values into the lower precision archives.
    
    This commit also bumps the package number as it introduces a breaking
    change to the create interface by making the xFilesFactor and new
    aggregationMethod arguments optional (defaulting to 0.5 and average
    respectively). Following semver.org recommendations that means a bump
    to the middle value :)
    
    Signed-off-by: ciaranj <[email protected]>
    ciaranj committed Oct 15, 2012
    Configuration menu
    Copy the full SHA
    76820e5 View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2012

  1. Add in required assert module

    Signed-off-by: ciaranj <[email protected]>
    ciaranj committed Nov 2, 2012
    Configuration menu
    Copy the full SHA
    b5efad4 View commit details
    Browse the repository at this point in the history

Commits on Mar 29, 2013

  1. Configuration menu
    Copy the full SHA
    c2d7df9 View commit details
    Browse the repository at this point in the history