Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing two issues with latest Node JS #7

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jsastriawan
Copy link

Hi Carl,

I am interested to use Hoard time series database as a storage for upcoming features I am working on Meshcentral. However I discover two issues, one is related to path.fileExistsSync that has been moved to fs.fileExistsSync and buffer_ieee754 reference (adding .js) extension.

I made this two changes and it seems working well with Node JS 6.10.1. Please merge this so that we can get a working Hoard library.

Regards,

Joko Sastriawan

ExistsSync has been moved to fs for latest Node js
Apparently recent nodejs is very picky about referring module without .js
@jnovack
Copy link

jnovack commented Sep 28, 2018

/opt # node -v
v6.14.4
/opt # node_modules/coffee-script/bin/coffee -c -l -b --no-header -o lib src
/opt/src/hoard.coffee:253:13: error: unexpected identifier
            updateArchiveCalls = []
            ^^^^^^^^^^^^^^^^^^

Doesn't build under node v6.14 and coffee-script v1.12.

Do you have ANY version which generated a good .js file?

I wanted to upgrade this to use Promises and ES6 (for fun?) but can't get it out of this GOD AWFUL CoffeeScript.

There's something funky in the updateMany section that CoffeeScript does not even like even when it's the sole function in the file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants