Exhaustive match
#50
Merged
Exhaustive match
#50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes
matchexpressions exhaustive, meaning that every value of a type has to be matched by a match arm. If an expression is not matched exhaustively, anEvaluationErrorwill be thrown.This should ensure correctness in chaiNNer's nodes. I noticed that it was quite easy to write
matchexpressions for enums and forget one variant. The only way to find out was to go through all possible enum values in the UI. This just isn't scalable, because we frequently add new variants to enum inputs.If the old behavior if desired, use a default match
_ => neverat the end of the match expression.