use native clipboard on macos #2031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just to give you a comparison. New implementation
Current implementation
|
|
FYI this does not close #958. That issue is with the copy to clipboard node, not frontend copy/paste. That issue will be resolved when we switch from pasteboard to a custom rust binding |
|
Ah, I see. Removed the issue from the message. So I better re-add pasteboard for the moment? |
|
yes, you should not remove pasteboard in this. |
|
Okay, reverted the changes. Pasteboard is back in. |
On macOS we need the native Edit menu to make all keyboard shortcuts accessable. The shortcuts can copy/cut/paste text and nodes. But using entries from the menu itself only interacts with text. Therefore on macOS a new menu is added: "Nodes" Menu structure: *Nodes | |- Undo |- Redo |-------- |- Cut |- Copy |- Paste |-------- |- Duplicate |- Duplicate with Connections This menus sole purpose is to give the user a menu to interact with Nodes. closes chaiNNer-org#1590
The View Menu is now located between Edit and Nodes to align it more with the default menu structure on macOS. Also the Window Menu used on Macs has been added.
|
Here is the new menu on macOS in action.
|
I never used macOS, so I had no idea such a thing even exists. Thank you for fixing this! |
RunDevelopment
approved these changes
Aug 2, 2023
|
I can't test this, but the code looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On macOS we need the native Edit menu to make all keyboard shortcuts accessable.
The shortcuts can copy/cut/paste text and nodes. But using entries from the menu itself only interacts with text.
Therefore on macOS a new menu is added: "Nodes"
Menu structure:
This menus sole purpose is to give the user a menu to interact with Nodes.
closes #1590