Add a way to set & get general settings #2189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2088 needs a way to set and get general settings for use by the backend. I have added that way of doing that in this PR, even though it is currently not used for anything.
In an ideal world, these general settings would also be defined by the backend. However, I don't want @stonerl to have to redo his whole PR more than he already has to. I'd much rather have him just adopt this system and we can move over stuff later.
If it's not clear, you would call
setGeneralBackendSettingon the frontend to set a general setting, andfrom settings import get_global_settingsto get the method that gets the settings.